Add an AuthenticationChallenge class.

Add an AuthenticationChallenge class.

A simpler version of this existed already in dart-lang/oauth2; this
makes it widely available and more robust.

R=rnystrom@google.com

Committed: https://github.com/dart-lang/http_parser/commit/bb521dd6fb0943b669236788a9244dd2f965ee80

[Bob Nystrom, 2015-08-25 21:28:59]

https://codereview.chromium.org/1307353003/diff/1/lib/src/authentication_chal...
File lib/src/authentication_challenge.dart (right):

https://codereview.chromium.org/1307353003/diff/1/lib/src/authentication_chal...
lib/src/authentication_challenge.dart:24: /// This is normalized to always be
lower-case.
"lowercase".

https://codereview.chromium.org/1307353003/diff/1/lib/src/authentication_chal...
lib/src/authentication_challenge.dart:112: }
These ~10 lines are copy/pasted from above. Can you refactor and share this
code?

https://codereview.chromium.org/1307353003/diff/1/lib/src/authentication_chal...
lib/src/authentication_challenge.dart:142: /// If [parameters] isn't passed, it
defaults to an empty map.
Make the parameter actually optional?

https://codereview.chromium.org/1307353003/diff/1/test/authentication_challen...
File test/authentication_challenge_test.dart (right):

https://codereview.chromium.org/1307353003/diff/1/test/authentication_challen...
test/authentication_challenge_test.dart:95: });
Test that it doesn't normalize the parameter value.

https://codereview.chromium.org/1307353003/diff/1/test/authentication_challen...
test/authentication_challenge_test.dart:115: });
What about a trailing comma?

[nweiz, 2015-08-25 22:02:08]

https://codereview.chromium.org/1307353003/diff/1/lib/src/authentication_chal...
File lib/src/authentication_challenge.dart (right):

https://codereview.chromium.org/1307353003/diff/1/lib/src/authentication_chal...
lib/src/authentication_challenge.dart:24: /// This is normalized to always be
lower-case.
On 2015/08/25 21:28:59, Bob Nystrom wrote:
> "lowercase".

Done.

https://codereview.chromium.org/1307353003/diff/1/lib/src/authentication_chal...
lib/src/authentication_challenge.dart:112: }
On 2015/08/25 21:28:59, Bob Nystrom wrote:
> These ~10 lines are copy/pasted from above. Can you refactor and share this
> code?

Done.

https://codereview.chromium.org/1307353003/diff/1/lib/src/authentication_chal...
lib/src/authentication_challenge.dart:142: /// If [parameters] isn't passed, it
defaults to an empty map.
On 2015/08/25 21:28:59, Bob Nystrom wrote:
> Make the parameter actually optional?

It actually shouldn't be optional, and this documentation shouldn't exist.

https://codereview.chromium.org/1307353003/diff/1/test/authentication_challen...
File test/authentication_challenge_test.dart (right):

https://codereview.chromium.org/1307353003/diff/1/test/authentication_challen...
test/authentication_challenge_test.dart:95: });
On 2015/08/25 21:28:59, Bob Nystrom wrote:
> Test that it doesn't normalize the parameter value.

Done.

https://codereview.chromium.org/1307353003/diff/1/test/authentication_challen...
test/authentication_challenge_test.dart:115: });
On 2015/08/25 21:28:59, Bob Nystrom wrote:
> What about a trailing comma?

Done.

[nweiz, 2015-08-25 22:02:26]

Code review changes

[Bob Nystrom, 2015-08-25 22:23:36]

lgtm

[nweiz, 2015-08-25 23:26:54]

Committed patchset #2 (id:20001) manually as
bb521dd6fb0943b669236788a9244dd2f965ee80 (presubmit successful).