Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1307353002: Band-aid fix for issue #24191. (Closed)

Created:
5 years, 4 months ago by Paul Berry
Modified:
5 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Band-aid fix for issue #24191. This is sufficient to avoid throwing an exception in the resolver, which in turn will prevent the analysis server from going into an infinite analysis loop. I'll work on a more complete fix (which infers the proper type in all cases) for the next release. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/b547acc88375ecbfd336059cc7893225b3a3ba17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 4 months ago (2015-08-24 22:58:14 UTC) #2
Brian Wilkerson
LGTM
5 years, 4 months ago (2015-08-24 23:04:33 UTC) #3
Paul Berry
5 years, 4 months ago (2015-08-24 23:05:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b547acc88375ecbfd336059cc7893225b3a3ba17 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698