Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1307323003: Don't allow variables to overwrite the frame edge. (Closed)

Created:
5 years, 4 months ago by turnidge
Modified:
5 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't allow variables to overwrite the frame edge. Make the variables demand a bit more room in general. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/d6060d2dddcea1d28fd6bde67afc25b089e352f0

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M runtime/observatory/lib/src/elements/debugger.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
5 years, 4 months ago (2015-08-24 21:20:32 UTC) #2
Cutch
lgtm
5 years, 4 months ago (2015-08-24 21:22:32 UTC) #3
turnidge
5 years, 3 months ago (2015-08-25 19:52:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d6060d2dddcea1d28fd6bde67afc25b089e352f0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698