Issue 1307283002: Fix profiler test failure on simulator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1307283002: Fix profiler test failure on simulator (Closed)

Created:
5 years, 4 months ago by Cutch

Modified:
5 years, 4 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix profiler test failure on simulator BUG= Committed: https://github.com/dart-lang/sdk/commit/8e1d5f181c9ed73a3d8d23be24978f53cb94bcab

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	runtime/vm/profiler_test.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

Committed patchset #1 (id:1) manually as 8e1d5f181c9ed73a3d8d23be24978f53cb94bcab (presubmit successful).

5 years, 4 months ago (2015-08-24 19:02:35 UTC) #3

siva

5 years, 4 months ago (2015-08-24 20:18:26 UTC) #4

Message was sent while issue was closed.

LGTM.

Maybe beneficial to define a macro

PROFILER_TEST_CASE and include
DisableNativeProfileScope dnps;

in it to ensure that people adding new tests do not miss it.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages