Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1307143004: Make navigation notification operation Source based, without Dart knowledge. (Closed)

Created:
5 years, 3 months ago by scheglov
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make navigation notification operation Source based, without Dart knowledge. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0e6eec7968a445801178d386210dde6c35488851

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -38 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 4 chunks +28 lines, -14 lines 0 comments Download
M pkg/analysis_server/test/plugin/set_analysis_domain_test.dart View 4 chunks +5 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 3 months ago (2015-09-09 16:58:07 UTC) #1
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-09-09 17:01:40 UTC) #2
scheglov
5 years, 3 months ago (2015-09-09 17:02:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0e6eec7968a445801178d386210dde6c35488851 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698