Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1307123004: Add SourceLocationMixin and SourceLocationBase. (Closed)

Created:
5 years, 3 months ago by nweiz
Modified:
5 years, 3 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/source_span@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add SourceLocationMixin and SourceLocationBase. This allows FileLocation to avoid extending SourceLocation at all, which avoids unused line, column, and sourceUrl fields. This produces a speed improvement of approximately 5% in the YAML parser, and will likely do more in code that uses locations more heavily relative to spans. R=rnystrom@google.com Committed: https://github.com/dart-lang/source_span/commit/0ca6f8032e0f51e806cbb1e540fccd661c82e77a

Patch Set 1 #

Patch Set 2 : Add a missing import. #

Total comments: 2

Patch Set 3 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -6 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/source_span.dart View 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/file.dart View 1 2 chunks +7 lines, -4 lines 0 comments Download
M lib/src/location.dart View 2 chunks +14 lines, -1 line 0 comments Download
A lib/src/location_mixin.dart View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
5 years, 3 months ago (2015-09-02 18:45:01 UTC) #1
Bob Nystrom
lgtm https://codereview.chromium.org/1307123004/diff/20001/lib/src/location_mixin.dart File lib/src/location_mixin.dart (right): https://codereview.chromium.org/1307123004/diff/20001/lib/src/location_mixin.dart#newcode43 lib/src/location_mixin.dart:43: other is SourceLocation && sourceUrl == other.sourceUrl && ...
5 years, 3 months ago (2015-09-02 19:39:50 UTC) #2
nweiz
Code review changes
5 years, 3 months ago (2015-09-02 20:31:57 UTC) #3
nweiz
Committed patchset #3 (id:40001) manually as 0ca6f8032e0f51e806cbb1e540fccd661c82e77a (presubmit successful).
5 years, 3 months ago (2015-09-02 20:32:06 UTC) #4
nweiz
5 years, 3 months ago (2015-09-02 20:33:05 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/1307123004/diff/20001/lib/src/location_mixin....
File lib/src/location_mixin.dart (right):

https://codereview.chromium.org/1307123004/diff/20001/lib/src/location_mixin....
lib/src/location_mixin.dart:43: other is SourceLocation && sourceUrl ==
other.sourceUrl &&
On 2015/09/02 19:39:50, Bob Nystrom wrote:
> Split after the first "&&" too.

Done.

Powered by Google App Engine
This is Rietveld 408576698