Issue 13070003: Do not use object pool for VM heap objects on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13070003: Do not use object pool for VM heap objects on ARM. (Closed)

Created:
7 years, 9 months ago by regis

Modified:
7 years, 9 months ago

Reviewers:
zra

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Do not use object pool for VM heap objects on ARM. Update decoding of call pattern accordingly. Add missing store barrier when storing object pool in instructions object. Work with GrowableObjectArray in old heap space when assembling object pool. Committed: https://code.google.com/p/dart/source/detail?r=20483

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+97 lines, -62 lines)			Patch
M	runtime/vm/assembler_arm.cc	View	1	8 chunks	+24 lines, -20 lines	0 comments	Download
M	runtime/vm/instructions_arm.h	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/instructions_arm.cc	View	1	4 chunks	+55 lines, -27 lines	0 comments	Download
M	runtime/vm/object.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	3 chunks	+13 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

7 years, 9 months ago (2013-03-25 20:29:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20483 (presubmit successful).

Expand Messages | Collapse Messages