Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 1306773005: dart2js cps: Change type tests to null tests when applicable. (Closed)

Created:
5 years, 3 months ago by asgerf
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Change type tests to null tests when applicable. When null is the only value that might fail a type test we can rewrite it to just compare against null. Update: Fixed a missing mandatory named parameter. R=kmillikin@google.com, sra@google.com Committed: https://github.com/dart-lang/sdk/commit/29dedfa97e3ff513d93b89c69c6b42b9746925d6 Reverted: https://github.com/dart-lang/sdk/commit/e97d32be50504c965b2f598f7f833b54be066fdf Committed: https://github.com/dart-lang/sdk/commit/cd901e78136644983e5933451248a53ac23a149b

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Pass 'allowNull' mandatory named parameter to 'isSubtypeOf' #

Patch Set 4 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 2 3 2 chunks +28 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
asgerf
5 years, 3 months ago (2015-09-03 18:34:58 UTC) #2
Kevin Millikin (Google)
lgtm
5 years, 3 months ago (2015-09-04 08:08:05 UTC) #3
sra1
lgtm
5 years, 3 months ago (2015-09-09 17:47:50 UTC) #4
asgerf
Committed patchset #1 (id:1) manually as 29dedfa97e3ff513d93b89c69c6b42b9746925d6 (presubmit successful).
5 years, 3 months ago (2015-09-21 11:33:21 UTC) #5
asgerf
PTAL. I was missing a mandatory named parameter "allowNull". The naming of the parameter is ...
5 years, 3 months ago (2015-09-21 13:41:26 UTC) #7
asgerf
5 years, 2 months ago (2015-10-14 09:35:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:80001) manually as
cd901e78136644983e5933451248a53ac23a149b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698