Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1306083003: Sort top-level constants before other top-level variables. (Closed)

Created:
5 years, 4 months ago by scheglov
Modified:
5 years, 4 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Sort top-level constants before other top-level variables. R=danrubel@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/aea1e572a1f2b13c8007ffbfc3cf5eccd2bac66d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -7 lines) Patch
M pkg/analysis_server/lib/src/services/correction/sort_members.dart View 4 chunks +15 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/correction/sort_members_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 4 months ago (2015-08-21 19:12:43 UTC) #1
danrubel
LGTM. Thank you!
5 years, 4 months ago (2015-08-21 19:15:36 UTC) #2
scheglov
5 years, 4 months ago (2015-08-21 19:19:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aea1e572a1f2b13c8007ffbfc3cf5eccd2bac66d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698