|
|
VM: Simplify irregexp entry stub.
Pass on the incoming arguments descriptor when invoking an irregexp function.
Avoiding loading an arguments descriptor in the intrinsic code also allows
generated regexp code in precompiled code.
Loading a new descriptor is not necessary since the arguments are already on
the stack in the right order.
Use named constants for parameter indices in the regexp assembler.
BUG=
R=srdjan@google.com
Committed: https://github.com/dart-lang/sdk/commit/7e40108ff5175a5aee2c5a5863eaeabe3a6e6b37
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+34 lines, -37 lines) |
Patch |
 |
M |
runtime/lib/regexp.cc
|
View
|
1
|
2 chunks |
+2 lines, -9 lines |
0 comments
|
Download
|
|
M |
runtime/vm/flow_graph_type_propagator.cc
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
runtime/vm/intrinsifier_arm.cc
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
runtime/vm/intrinsifier_arm64.cc
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
runtime/vm/intrinsifier_ia32.cc
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
runtime/vm/intrinsifier_mips.cc
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
runtime/vm/intrinsifier_x64.cc
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
runtime/vm/regexp.cc
|
View
|
1
|
1 chunk |
+12 lines, -4 lines |
0 comments
|
Download
|
|
M |
runtime/vm/regexp_assembler.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
runtime/vm/regexp_assembler_ir.h
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
runtime/vm/regexp_assembler_ir.cc
|
View
|
1
|
2 chunks |
+14 lines, -7 lines |
0 comments
|
Download
|
|
M |
runtime/vm/regexp_test.cc
|
View
|
1
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
Total messages: 4 (1 generated)
|
Chromium Code Reviews
Issue
1305993005:
VM: Simplify irregexp entry stub. (Closed)
