Improve strong-mode implementation and fix several failing tests

There are several improvements:
- analyzer no longer reports errors in the initializers for static variables until the final resolution
- the collection of static variables is now computed more efficiently
- an unused analysis result is no longer being computed

In addition, this fixes several (but not all) of the tests that fail when the task model is enabled.

R=paulberry@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/38bf731d54beb65bcf7c2f153f462cc56c141de4

[Brian Wilkerson, 2015-09-08 15:23:10]

brianwilkerson@google.com changed reviewers:
+ leafp@google.com, paulberry@google.com, scheglov@google.com

[scheglov, 2015-09-08 15:36:22]

lgtm

https://codereview.chromium.org/1305863011/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/1305863011/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:8420: class DisablableErrorListener
implements AnalysisErrorListener {
Why don't we put it in error.dart ?

[Paul Berry, 2015-09-08 16:13:30]

lgtm

https://codereview.chromium.org/1305863011/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1305863011/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:9558: bool strongMode;
This could be made final.

https://codereview.chromium.org/1305863011/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:9561: * The static variables that
should have types inferred for them. The list
This comment is misleading, since we add *all* static variables to the list in
strong mode, not just those that need static type inference.

Consider changing to say something like "If [strongMode] is true, a list of
static variables that have been visited.  Otherwise, an empty list."

https://codereview.chromium.org/1305863011/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:9614: bool wasDiscarded =
discardErrorsInInitializer;
Suggestion: rename "wasDiscarded" to "wasDiscarding".  "Discarded" makes it
sound like the errors were discarded at some point in the past.

https://codereview.chromium.org/1305863011/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:9641: bool wasDiscarded =
discardErrorsInInitializer;
Similar suggestion here.

https://codereview.chromium.org/1305863011/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1305863011/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:3425: // this needs to happen later.
I'm having trouble understanding this comment.  Would it be possible to rephrase
it as a "TODO" indicating what needs to be changed?

[Brian Wilkerson, 2015-09-08 17:10:33]

https://codereview.chromium.org/1305863011/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/1305863011/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:8420: class DisablableErrorListener
implements AnalysisErrorListener {
Done

https://codereview.chromium.org/1305863011/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1305863011/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:9558: bool strongMode;
Done

https://codereview.chromium.org/1305863011/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:9561: * The static variables that
should have types inferred for them. The list
> This comment is misleading, since we add *all* static variables to the list in
> strong mode, not just those that need static type inference.

Actually, that's not true either. We only add static variables that have an
initializer. Comment updated.

https://codereview.chromium.org/1305863011/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:9614: bool wasDiscarded =
discardErrorsInInitializer;
Done

https://codereview.chromium.org/1305863011/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:9641: bool wasDiscarded =
discardErrorsInInitializer;
Done

https://codereview.chromium.org/1305863011/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1305863011/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:3425: // this needs to happen later.
Actually, it looks like the consensus is to remove propagation of return types
for top-level function declarations, which will make this comment obsolete. I'll
remove the comment in the next CL (when I remove static return type
propagation).

[Brian Wilkerson, 2015-09-08 17:12:24]

Committed patchset #2 (id:20001) manually as
38bf731d54beb65bcf7c2f153f462cc56c141de4 (presubmit successful).