Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 1305863010: dart2js cps: Store the TypeMask for each primitive in a field. (Closed)

Created:
5 years, 3 months ago by asgerf
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Store the TypeMask for each primitive in a field. This should make it easier to use type information in other passes. Some passes have been adapted to update the type field, even though it is still only used in type propagation. Refinement nodes are still removed pretty early since most passes are not prepared to deal with them. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/79c0cb039f7c5a5b98af3d641aa5b6b30cb31927

Patch Set 1 #

Patch Set 2 : Long line #

Total comments: 1

Patch Set 3 : Print type in CPS IR tracer #

Total comments: 2

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -60 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 9 chunks +22 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 1 2 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart View 1 2 4 chunks +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/insert_refinements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/loop_invariant_code_motion.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/mutable_ssa.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/redundant_join.dart View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/scalar_replacement.dart View 5 chunks +9 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/share_interceptors.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 17 chunks +44 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
asgerf
https://codereview.chromium.org/1305863010/diff/20001/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart File pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart (right): https://codereview.chromium.org/1305863010/diff/20001/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart#newcode1139 pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart:1139: abstract class Variable<T extends Variable<T>> extends Definition<T> { I ...
5 years, 3 months ago (2015-09-08 14:49:49 UTC) #2
Kevin Millikin (Google)
lgtm https://codereview.chromium.org/1305863010/diff/40001/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart File pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart (right): https://codereview.chromium.org/1305863010/diff/40001/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart#newcode515 pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart:515: final TypeMask refineType; refineType sounds like a verb. ...
5 years, 3 months ago (2015-09-09 10:12:47 UTC) #3
asgerf
https://codereview.chromium.org/1305863010/diff/40001/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart File pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart (right): https://codereview.chromium.org/1305863010/diff/40001/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart#newcode515 pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart:515: final TypeMask refineType; On 2015/09/09 10:12:47, Kevin Millikin (Google) ...
5 years, 3 months ago (2015-09-09 13:08:10 UTC) #4
asgerf
5 years, 3 months ago (2015-09-15 11:05:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
79c0cb039f7c5a5b98af3d641aa5b6b30cb31927 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698