[dart2js] fix inference of ??= and []??=

[dart2js] fix inference of ??= and []??=
Fixes #24134
Fixes #24135

R=floitsch@google.com, johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/6e0b2418c7024406f603c2c775d320484355a449

[Siggi Cherem (dart-lang), 2015-08-20 01:31:30]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2015-08-20 01:39:47]

sigmund@google.com changed reviewers:
+ het@google.com

[Siggi Cherem (dart-lang), 2015-08-20 01:39:47]

https://codereview.chromium.org/1305663002/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart (right):

https://codereview.chromium.org/1305663002/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart:893: } else if
(Elements.isUnresolved(element)
BTW - this looks like a bigger change than it is - there is very little new code
here.

Basically the code had this structure:

   1. for each condition:
     1.1 compute getterType
     1.2 compute newType by doing the getter & operator send
     1.3 handle the assignment through the setter


1.2 was identical in all cases, so I changed it to have this structure instead:


   1. for each condition:
     1.1 compute getterType

   2. compute newType by doing the getter & operator send

   3. for each condition:
     3.3 handle the assignment (as before)


and then modified #2 to include the logic for `??=`

[floitsch, 2015-08-20 11:49:51]

floitsch@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-08-20 11:49:52]

LGTM.

[Johnni Winther, 2015-08-20 12:31:31]

johnniwinther@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2015-08-20 12:31:32]

lgtm

[Siggi Cherem (dart-lang), 2015-08-20 14:32:42]

Committed patchset #1 (id:20001) manually as
6e0b2418c7024406f603c2c775d320484355a449 (presubmit successful).