Issue 130563005: Fix dartbug.com/15963:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 130563005: Fix dartbug.com/15963: (Closed)

Created:
6 years, 11 months ago by Ivan Posva

Modified:
6 years, 11 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix dartbug.com/15963: - Properly serialize and deserialize RawInstance which represent the Object class. - Initialize the last word to null even for AllocateUnitialized to ensure the properly formed objects even for misaligned objects. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=31765

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -5 lines)			Patch
M	runtime/vm/raw_object_snapshot.cc	View	3 chunks	+41 lines, -5 lines	0 comments	Download
M	runtime/vm/snapshot.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/snapshot.cc	View	2 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

6 years, 11 months ago (2014-01-13 22:46:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r31765 (presubmit successful).

Expand Messages | Collapse Messages