Issue 130563004: Redo "Make dart2js typed_data implementation classes private"

Issue 130563004: Redo "Make dart2js typed_data implementation classes private" (Closed)

Created:
6 years, 11 months ago by sra1

Modified:
6 years, 11 months ago

Reviewers:
Cutch, blois, floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Redo "Make dart2js typed_data implementation classes private" The main library is now private, with the user visible library as small re-export library. R=blois@google.com, floitsch@google.com, johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31865

Patch Set 3 : add missing file #

Patch Set 4 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+726 lines, -2846 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/elements.dart	View	1 2	1 chunk	+10 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/native_handler.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/libraries.dart	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	sdk/lib/html/html_common/conversions.dart	View	1	4 chunks	+5 lines, -5 lines	0 comments	Download
M	sdk/lib/html/html_common/html_common_dart2js.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	sdk/lib/typed_data/dart2js/native_typed_data_dart2js.dart	View	1 2	51 chunks	+640 lines, -190 lines	0 comments	Download
M	sdk/lib/typed_data/dart2js/typed_data_dart2js.dart	View	1	1 chunk	+21 lines, -2605 lines	0 comments	Download
M	sdk/lib/web_audio/dart2js/web_audio_dart2js.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/web_gl/dart2js/web_gl_dart2js.dart	View	1	4 chunks	+7 lines, -7 lines	0 comments	Download
M	tools/dom/scripts/dartmetadata.py	View	1	4 chunks	+17 lines, -15 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/html_dart2js.darttemplate	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/dart2js/indexed_db_dart2js.darttemplate	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/dart2js/web_audio_dart2js.darttemplate	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/dart2js/web_gl_dart2js.darttemplate	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sra1

The original CL was rolled back because of weakly-related bug with interceptors and IE. The ...

6 years, 11 months ago (2014-01-15 06:22:25 UTC) #1

floitsch

LGTM. https://codereview.chromium.org/130563004/diff/110001/sdk/lib/_internal/compiler/implementation/elements/elements.dart File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right): https://codereview.chromium.org/130563004/diff/110001/sdk/lib/_internal/compiler/implementation/elements/elements.dart#newcode574 sdk/lib/_internal/compiler/implementation/elements/elements.dart:574: //if (cls == null) return false; Remove? https://codereview.chromium.org/130563004/diff/110001/sdk/lib/_internal/libraries.dart ...

6 years, 11 months ago (2014-01-15 09:33:30 UTC) #2

sra1

https://codereview.chromium.org/130563004/diff/110001/sdk/lib/_internal/compiler/implementation/elements/elements.dart File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right): https://codereview.chromium.org/130563004/diff/110001/sdk/lib/_internal/compiler/implementation/elements/elements.dart#newcode574 sdk/lib/_internal/compiler/implementation/elements/elements.dart:574: //if (cls == null) return false; On 2014/01/15 09:33:30, ...

6 years, 11 months ago (2014-01-15 20:13:41 UTC) #4

sra1

6 years, 11 months ago (2014-01-16 04:28:03 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r31865 (presubmit successful).

Expand Messages | Collapse Messages