No more warnings for duplicate unnamed lib imports.

No more warnings for duplicate unnamed lib imports

Fixes #24156.

R=brianwilkerson@google.com, paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/67e988bb9f52424ddfa442a2bafda00bd33a0d7a

[pquitslund, 2015-08-20 20:54:57]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, paulberry@google.com

[pquitslund, 2015-08-20 20:54:58]

Note that there do not seem to be any corresponding shared tests to update.

[Paul Berry, 2015-08-20 20:57:37]

We should add a shared test before landing this CL.  Some other minor comments
below.

https://codereview.chromium.org/1305433005/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/static_warning_code_test.dart (right):

https://codereview.chromium.org/1305433005/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/static_warning_code_test.dart:1275:
assertErrors(source, [
Use assertNoErrors() and move this test into the NonErrorReolverTest class.

https://codereview.chromium.org/1305433005/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/static_warning_code_test.dart:1502: // No warning
(https://github.com/dart-lang/sdk/issues/24156)
I think this test should be moved into NonErrorResolverTest as well.

[Brian Wilkerson, 2015-08-20 21:11:07]

LGTM once Paul's comments are addressed

[Bob Nystrom, 2015-08-20 21:21:54]

rnystrom@google.com changed reviewers:
+ rnystrom@google.com

[Bob Nystrom, 2015-08-20 21:21:55]

\o/ \o/ \o/ \o/

[pquitslund, 2015-08-20 21:23:42]

pquitslund@google.com changed reviewers:
- rnystrom@google.com

[pquitslund, 2015-08-20 21:23:43]

Thanks! 

Comments addressed.

https://codereview.chromium.org/1305433005/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/static_warning_code_test.dart (right):

https://codereview.chromium.org/1305433005/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/static_warning_code_test.dart:1275:
assertErrors(source, [
On 2015/08/20 20:57:37, Paul Berry wrote:
> Use assertNoErrors() and move this test into the NonErrorReolverTest class.

Good call.  Done!

https://codereview.chromium.org/1305433005/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/static_warning_code_test.dart:1502: // No warning
(https://github.com/dart-lang/sdk/issues/24156)
On 2015/08/20 20:57:37, Paul Berry wrote:
> I think this test should be moved into NonErrorResolverTest as well.

Works for me.  Done.

[Paul Berry, 2015-08-20 21:29:57]

lgtm

[pquitslund, 2015-08-20 21:30:41]

Committed patchset #2 (id:20001) manually as
67e988bb9f52424ddfa442a2bafda00bd33a0d7a (presubmit successful).