Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 1305413004: Add source annotations for breakpoints. (Closed)

Created:
5 years, 3 months ago by turnidge
Modified:
5 years, 3 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -9 lines) Patch
M runtime/observatory/lib/src/elements/script_inset.dart View 1 2 12 chunks +94 lines, -6 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_inset.html View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
5 years, 3 months ago (2015-08-31 17:22:18 UTC) #2
rmacnak
lgtm
5 years, 3 months ago (2015-08-31 18:30:25 UTC) #3
turnidge
5 years, 3 months ago (2015-08-31 19:10:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
535f57a84a7e3a742bf5869aaf360e76c14cca92 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698