Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1305273005: Mentioning null-aware in 1.12 changelog (Closed)

Created:
5 years, 4 months ago by mit
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Small changes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M CHANGELOG.md View 1 1 chunk +8 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
mit
5 years, 4 months ago (2015-08-25 09:25:05 UTC) #2
Johnni Winther
lgtm
5 years, 4 months ago (2015-08-25 09:29:01 UTC) #3
mit
Committed patchset #2 (id:20001) manually as 8c346abeef17e95f06c8c7e1c49474d03ac4a2b2 (presubmit successful).
5 years, 4 months ago (2015-08-25 09:34:56 UTC) #4
eernst
5 years, 4 months ago (2015-08-25 12:28:36 UTC) #5
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/1305273005/diff/20001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/1305273005/diff/20001/CHANGELOG.md#newcode25
CHANGELOG.md:25: * `x?.m()`: null-aware method invocation. `x?.m()` invokes `m`
only if `x` is not `null`.
You could say that the reader of this announcement could as well go to the spec
and read about the details, so maybe there is no need to have this summary here.

Otherwise, it might be nice to make it explicitly inofficial: "

```
* Null-aware operators implemented. Informal summary of the semantics:
    * `??`: ...
```

Powered by Google App Engine
This is Rietveld 408576698