Issue 130503005: Retry file deletions in pub on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 130503005: Retry file deletions in pub on Windows. (Closed)

Created:
6 years, 11 months ago by nweiz

Modified:
6 years, 11 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Retry file deletions in pub on Windows. R=rnystrom@google.com BUG=16129 Committed: https://code.google.com/p/dart/source/detail?r=31900

Patch Set 2 : code review #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -9 lines)			Patch
	M	sdk/lib/_internal/pub/lib/src/io.dart	View	1	1 chunk	+39 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One suggestion then LGTM. https://codereview.chromium.org/130503005/diff/1/sdk/lib/_internal/pub/lib/src/io.dart File sdk/lib/_internal/pub/lib/src/io.dart (right): https://codereview.chromium.org/130503005/diff/1/sdk/lib/_internal/pub/lib/src/io.dart#newcode332 sdk/lib/_internal/pub/lib/src/io.dart:332: "Retrying."); You should sleep a ...

6 years, 11 months ago (2014-01-16 21:37:45 UTC) #2

nweiz

https://codereview.chromium.org/130503005/diff/1/sdk/lib/_internal/pub/lib/src/io.dart File sdk/lib/_internal/pub/lib/src/io.dart (right): https://codereview.chromium.org/130503005/diff/1/sdk/lib/_internal/pub/lib/src/io.dart#newcode332 sdk/lib/_internal/pub/lib/src/io.dart:332: "Retrying."); On 2014/01/16 21:37:46, Bob Nystrom wrote: > You ...

6 years, 11 months ago (2014-01-16 22:26:33 UTC) #3

nweiz

6 years, 11 months ago (2014-01-16 22:28:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r31900 (presubmit successful).

Expand Messages | Collapse Messages

Issue 130503005: Retry file deletions in pub on Windows. (Closed)

Description

Patch Set 1 #

Patch Set 2 : code review #

Messages