Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1304953004: Make build incremental (Closed)

Created:
5 years, 3 months ago by Cutch
Modified:
5 years, 3 months ago
Reviewers:
ricow1, siva, Ivan Posva
CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make build incremental - Make sure observatory's index.html is touched. - Switch generate_snapshot_bin to have only one output (a timestamp file) Fixes #24220 R=iposva@google.com, ricow@google.com Committed: https://github.com/dart-lang/sdk/commit/021d7c0aa539c47d868749f6cf1a8aa538f8b19f

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M runtime/bin/bin.gypi View 4 chunks +5 lines, -5 lines 0 comments Download
M runtime/tools/create_snapshot_bin.py View 3 chunks +15 lines, -0 lines 0 comments Download
M tools/observatory_tool.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 3 months ago (2015-08-27 14:49:13 UTC) #2
ricow1
lgtm https://codereview.chromium.org/1304953004/diff/1/runtime/tools/create_snapshot_bin.py File runtime/tools/create_snapshot_bin.py (right): https://codereview.chromium.org/1304953004/diff/1/runtime/tools/create_snapshot_bin.py#newcode83 runtime/tools/create_snapshot_bin.py:83: open(options.timestamp_file, 'w').close() does this actually change the timestamp ...
5 years, 3 months ago (2015-08-27 15:00:26 UTC) #3
Ivan Posva
LGTM -ip
5 years, 3 months ago (2015-08-27 15:24:58 UTC) #4
Cutch
5 years, 3 months ago (2015-08-27 18:14:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
021d7c0aa539c47d868749f6cf1a8aa538f8b19f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698