Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1304613002: Upstream change to also kill fletch as part of task_kill.py. (Closed)

Created:
5 years, 4 months ago by ricow1
Modified:
5 years, 4 months ago
Reviewers:
ahe, Bill Hesse
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Upstream change to also kill fletch as part of task_kill.py. This is to keep the patching of our branch as small as possible (and to guarantee consistency if we share bots between sdk and fletch runners) R=ahe@google.com, whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/171ca680ba4b67fa235293d8f0e41895f081da83

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M tools/task_kill.py View 5 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
5 years, 4 months ago (2015-08-19 09:28:07 UTC) #1
ahe
lgtm
5 years, 4 months ago (2015-08-19 09:29:16 UTC) #2
ricow1
5 years, 4 months ago (2015-08-20 07:33:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
171ca680ba4b67fa235293d8f0e41895f081da83 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698