Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 13046009: Fix issue 9442. (Closed)

Created:
7 years, 9 months ago by regis
Modified:
7 years, 9 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix issue 9442. Add regression test. Committed: https://code.google.com/p/dart/source/detail?r=20545

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -3 lines) Patch
M runtime/vm/flow_graph_type_propagator.cc View 2 chunks +10 lines, -3 lines 0 comments Download
A tests/language/function_type_alias8_test.dart View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
regis
7 years, 9 months ago (2013-03-26 20:37:52 UTC) #1
srdjan
LGTM with comments https://codereview.chromium.org/13046009/diff/1/tests/language/function_type_alias8_test.dart File tests/language/function_type_alias8_test.dart (right): https://codereview.chromium.org/13046009/diff/1/tests/language/function_type_alias8_test.dart#newcode40 tests/language/function_type_alias8_test.dart:40: var temp1 = Test.fromThingSimple(new Thing()); remove ...
7 years, 9 months ago (2013-03-26 21:05:34 UTC) #2
regis
Thanks. I simplified the test. https://codereview.chromium.org/13046009/diff/1/tests/language/language_dart2js.status File tests/language/language_dart2js.status (right): https://codereview.chromium.org/13046009/diff/1/tests/language/language_dart2js.status#newcode68 tests/language/language_dart2js.status:68: function_type_alias8_test: Fail # type ...
7 years, 9 months ago (2013-03-26 21:25:49 UTC) #3
regis
7 years, 9 months ago (2013-03-26 21:26:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20545 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698