Issue 1304473002: Ensure helper threads get empty initial store buffer block.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1304473002: Ensure helper threads get empty initial store buffer block. (Closed)

Created:
5 years, 4 months ago by koda

Modified:
5 years, 4 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Ensure helper threads get empty initial store buffer block. This is a temporary remedy for issue https://github.com/dart-lang/sdk/issues/24114 The proper solution is to iterate over and flush all threads when they are coordinating a safepoint. R=iposva@google.com TBR=iposva@google.com BUG=https://github.com/dart-lang/sdk/issues/24114 Committed: https://github.com/dart-lang/sdk/commit/645b809e636b7a396d805b2f8cc707ec3549c3e3

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	runtime/vm/thread.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Ivan Posva

On 2015/08/18 20:14:58, koda wrote: > The proper solution is to iterate over and flush ...

5 years, 4 months ago (2015-08-18 20:17:16 UTC) #3

koda

5 years, 4 months ago (2015-08-18 20:19:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
645b809e636b7a396d805b2f8cc707ec3549c3e3 (presubmit successful).