Issue 13044010: dom: more final more of the time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13044010: dom: more final more of the time (Closed)

Created:
7 years, 9 months ago by kevmoo-old

Modified:
7 years, 9 months ago

Reviewers:
Emily Fortuna, Andrei Mouravski, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Total comments: 1

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -16 lines)			Patch
M	sdk/lib/chrome/dart2js/chrome_dart2js.dart	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/dom/src/Isolates.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/src/Microtask.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/src/chrome/chrome.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/src/chrome/utils.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/dom/src/dart2js_DOMImplementation.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Andrei Mouravski

Is there a bug associated with this? It looks good, but are you sure there ...

7 years, 9 months ago (2013-03-28 17:22:22 UTC) #2

kevmoo-old

7 years, 9 months ago (2013-03-28 17:49:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r20625 (presubmit successful).