Issue 1304363004: Code review changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1304363004: Code review changes (Closed)

Created:
5 years, 3 months ago by nweiz

Modified:
5 years, 3 months ago

Reviewers:

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/oauth2.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+411 lines, -244 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+32 lines, -0 lines	0 comments	Download
M	README.md	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	lib/src/authorization_code_grant.dart	View	4 chunks	+45 lines, -14 lines	0 comments	Download
M	lib/src/client.dart	View	5 chunks	+25 lines, -12 lines	0 comments	Download
M	lib/src/credentials.dart	View	5 chunks	+46 lines, -29 lines	0 comments	Download
M	lib/src/handle_access_token_response.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	lib/src/utils.dart	View	1 chunk	+7 lines, -56 lines	0 comments	Download
M	pubspec.yaml	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/authorization_code_grant_test.dart	View	4 chunks	+71 lines, -5 lines	0 comments	Download
M	test/client_test.dart	View	11 chunks	+40 lines, -15 lines	0 comments	Download
M	test/credentials_test.dart	View	6 chunks	+135 lines, -17 lines	0 comments	Download
D	test/utils_test.dart	View	1 chunk	+0 lines, -88 lines	0 comments	Download

Total messages: 1 (0 generated)

nweiz

5 years, 3 months ago (2015-08-26 20:44:20 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3b3e3a6617f4f028ee6ee638ef690ba502d4645b (presubmit successful).