Issue 1304243005: Handle addError on a WebSocket

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1304243005: Handle addError on a WebSocket (Closed)

Created:
5 years, 3 months ago by Søren Gjesse

Modified:
5 years, 3 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Handle addError on a WebSocket A call to addError on a WebSocket will now close the connection and add the error to the associated stream. Using addError on a WebSocket is not that relevant as normally the close method is used to close with a possible error condition. BUG= https://github.com/dart-lang/sdk/issues/24278 R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/373dd4b33c1efd52ef0dc0ad2a5249263b6b506d

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -0 lines)			Patch
	M	sdk/lib/io/websocket_impl.dart	View		2 chunks	+11 lines, -0 lines	0 comments	Download
	M	tests/standalone/io/web_socket_error_test.dart	View		1 chunk	+99 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Søren Gjesse

5 years, 3 months ago (2015-09-07 06:29:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
373dd4b33c1efd52ef0dc0ad2a5249263b6b506d (presubmit successful).