Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 13042015: Various OpenGLUI changes: (Closed)

Created:
7 years, 8 months ago by gram
Modified:
7 years, 6 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Various OpenGLUI changes: - support for HTML5 canvas gradients (linear and radial) - support for AudioElement - support for Android accelerometer - images are now cached instead of being recreated every time they are drawn - we now try to call update_ at most at 60fps - various bug fixes - default Skia build is now release. This should just be based off the overall build but I wasn't able to get gyp to do that yet Committed: https://code.google.com/p/dart/source/detail?r=20598

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+914 lines, -233 lines) Patch
M runtime/embedders/openglui/android/android_input_handler.h View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/embedders/openglui/android/android_sound_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/embedders/openglui/android/eventloop.h View 2 chunks +14 lines, -0 lines 0 comments Download
M runtime/embedders/openglui/android/eventloop.cc View 11 chunks +96 lines, -9 lines 0 comments Download
M runtime/embedders/openglui/android/main.cc View 2 chunks +10 lines, -1 line 0 comments Download
M runtime/embedders/openglui/build_skia.sh View 4 chunks +11 lines, -6 lines 0 comments Download
M runtime/embedders/openglui/common/canvas_context.h View 2 chunks +21 lines, -12 lines 0 comments Download
M runtime/embedders/openglui/common/canvas_context.cc View 3 chunks +30 lines, -54 lines 0 comments Download
M runtime/embedders/openglui/common/canvas_state.h View 8 chunks +40 lines, -37 lines 0 comments Download
M runtime/embedders/openglui/common/canvas_state.cc View 3 chunks +113 lines, -0 lines 0 comments Download
M runtime/embedders/openglui/common/dart_host.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/embedders/openglui/common/extension.cc View 8 chunks +125 lines, -47 lines 0 comments Download
M runtime/embedders/openglui/common/gl.dart View 20 chunks +185 lines, -38 lines 4 comments Download
M runtime/embedders/openglui/common/graphics_handler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A runtime/embedders/openglui/common/image_cache.h View 1 chunk +58 lines, -0 lines 0 comments Download
A runtime/embedders/openglui/common/image_cache.cc View 1 chunk +99 lines, -0 lines 0 comments Download
M runtime/embedders/openglui/common/input_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/embedders/openglui/common/input_handler.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/embedders/openglui/common/log.h View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/embedders/openglui/common/opengl.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/embedders/openglui/common/resource.h View 2 chunks +4 lines, -3 lines 0 comments Download
M runtime/embedders/openglui/common/sample.h View 3 chunks +11 lines, -8 lines 0 comments Download
M runtime/embedders/openglui/common/sound_handler.h View 1 chunk +5 lines, -1 line 1 comment Download
M runtime/embedders/openglui/common/sound_handler.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M runtime/embedders/openglui/common/vm_glue.h View 2 chunks +12 lines, -1 line 0 comments Download
M runtime/embedders/openglui/common/vm_glue.cc View 3 chunks +20 lines, -2 lines 0 comments Download
M runtime/embedders/openglui/emulator/emulator_embedder.cc View 4 chunks +11 lines, -5 lines 0 comments Download
M runtime/embedders/openglui/emulator/emulator_graphics_handler.cc View 2 chunks +3 lines, -1 line 0 comments Download
M runtime/embedders/openglui/emulator/emulator_resource.h View 4 chunks +5 lines, -4 lines 0 comments Download
M runtime/embedders/openglui/openglui_embedder.gypi View 7 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
gram
7 years, 8 months ago (2013-03-27 18:13:07 UTC) #1
vsm
lgtm! https://codereview.chromium.org/13042015/diff/1/runtime/embedders/openglui/common/gl.dart File runtime/embedders/openglui/common/gl.dart (right): https://codereview.chromium.org/13042015/diff/1/runtime/embedders/openglui/common/gl.dart#newcode27 runtime/embedders/openglui/common/gl.dart:27: int scheduleCallback(callback, [argument]) { Make this private? It's ...
7 years, 8 months ago (2013-03-27 22:27:06 UTC) #2
gram
7 years, 8 months ago (2013-03-27 23:41:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20598.

Powered by Google App Engine
This is Rietveld 408576698