Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1304083008: Add ClassSet to support ClassWorld.strictSubtypesOf (Closed)

Created:
5 years, 3 months ago by Johnni Winther
Modified:
5 years, 3 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add ClassSet to support ClassWorld.strictSubtypesOf BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/7d4751dae831f203ab264ba9ab1fb901f9053602

Patch Set 1 #

Patch Set 2 : Cleanup. #

Total comments: 7

Patch Set 3 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+525 lines, -75 lines) Patch
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 3 chunks +8 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/universe/class_set.dart View 1 2 5 chunks +330 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/world.dart View 6 chunks +84 lines, -41 lines 0 comments Download
M tests/compiler/dart2js/class_set_test.dart View 12 chunks +19 lines, -13 lines 0 comments Download
A tests/compiler/dart2js/subtypeset_test.dart View 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
https://codereview.chromium.org/1304083008/diff/20001/pkg/compiler/lib/src/world.dart File pkg/compiler/lib/src/world.dart (left): https://codereview.chromium.org/1304083008/diff/20001/pkg/compiler/lib/src/world.dart#oldcode189 pkg/compiler/lib/src/world.dart:189: message: 'Class $cls has not been instantiated.')); We now ...
5 years, 3 months ago (2015-09-07 14:21:37 UTC) #2
Johnni Winther
ping
5 years, 3 months ago (2015-09-08 10:52:09 UTC) #3
karlklose
LGTM. https://codereview.chromium.org/1304083008/diff/20001/pkg/compiler/lib/src/universe/class_set.dart File pkg/compiler/lib/src/universe/class_set.dart (right): https://codereview.chromium.org/1304083008/diff/20001/pkg/compiler/lib/src/universe/class_set.dart#newcode138 pkg/compiler/lib/src/universe/class_set.dart:138: /// the subtypes that do not extends `C` ...
5 years, 3 months ago (2015-09-08 12:09:21 UTC) #5
Johnni Winther
Committed patchset #3 (id:40001) manually as 7d4751dae831f203ab264ba9ab1fb901f9053602 (presubmit successful).
5 years, 3 months ago (2015-09-08 13:09:36 UTC) #6
Johnni Winther
5 years, 3 months ago (2015-09-09 17:19:20 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1304083008/diff/20001/pkg/compiler/lib/src/un...
File pkg/compiler/lib/src/universe/class_set.dart (right):

https://codereview.chromium.org/1304083008/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/class_set.dart:138: /// the subtypes that do not
extends `C` through a list of additional
On 2015/09/08 12:09:21, karlklose wrote:
> 'extends' -> 'extend'.

Done.

https://codereview.chromium.org/1304083008/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/class_set.dart:164: /// The subtypes `B` and `E`
are not directly model because they are implied
On 2015/09/08 12:09:21, karlklose wrote:
> 'model' -> 'modeled'?

Done.

https://codereview.chromium.org/1304083008/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/class_set.dart:428: Iterator<ClassHierarchyNode>
iterables;
On 2015/09/08 12:09:21, karlklose wrote:
> Maybe change this to describe what the iterator holds (like in 'elements').
> hierarchyNodes?

Done.

Powered by Google App Engine
This is Rietveld 408576698