Moar constant caching

Moar constant caching

Insert all compile-time constants expression in the constant cache.

BUG=

Committed: https://github.com/dart-lang/sdk/commit/f286b5b8b6c2985c9ff3b6776e079b35a6197f8d

[hausner, 2015-09-01 21:30:37]

hausner@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2015-09-01 21:33:51]

LGTMwC

https://codereview.chromium.org/1303973007/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1303973007/diff/20001/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:10886: if (require_compiletime_const) {
How about skipping lookup if expr->IsLiteralNode()?

[hausner, 2015-09-01 21:37:39]

https://codereview.chromium.org/1303973007/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1303973007/diff/20001/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:10886: if (require_compiletime_const) {
On 2015/09/01 21:33:51, srdjan wrote:
> How about skipping lookup if expr->IsLiteralNode()?

The lookup happens before the expression is parsed, so we don't know whether
it's going to be a literal node. If we have a cache hit, the expression is
skipped (instead of parsed).

[hausner, 2015-09-01 21:43:08]

Committed patchset #2 (id:20001) manually as
f286b5b8b6c2985c9ff3b6776e079b35a6197f8d (presubmit successful).