Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 1303613003: Disable target_with_colon_test on Windows. (Closed)

Created:
5 years, 4 months ago by Harry Terkelsen
Modified:
5 years, 4 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Disable target_with_colon_test on Windows. Windows does not allow colons in paths. BUG= R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/714734b220ee8c82a26486b8aa446c0f2f5e8227

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tests/standalone/standalone.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Harry Terkelsen
5 years, 4 months ago (2015-08-19 23:48:13 UTC) #2
Ivan Posva
LGTM -ip https://codereview.chromium.org/1303613003/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/1303613003/diff/1/tests/standalone/standalone.status#newcode180 tests/standalone/standalone.status:180: package/scenarios/packages_file_strange_formatting/target_with_colon_test: Skip # Windows does not allow ...
5 years, 4 months ago (2015-08-19 23:54:29 UTC) #3
Harry Terkelsen
https://codereview.chromium.org/1303613003/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/1303613003/diff/1/tests/standalone/standalone.status#newcode180 tests/standalone/standalone.status:180: package/scenarios/packages_file_strange_formatting/target_with_colon_test: Skip # Windows does not allow colons in ...
5 years, 4 months ago (2015-08-19 23:58:02 UTC) #4
Harry Terkelsen
5 years, 4 months ago (2015-08-19 23:58:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
714734b220ee8c82a26486b8aa446c0f2f5e8227 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698