Cleanup of function_set.dart

Cleanup of function_set.dart

BUG=
R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/df3b310e683cbd094bf5be054f9979a66303708a

[Johnni Winther, 2015-09-01 07:21:02]

johnniwinther@google.com changed reviewers:
+ karlklose@google.com, sigmund@google.com

[karlklose, 2015-09-01 07:47:03]

LGTM.

https://codereview.chromium.org/1303363006/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/function_set.dart (right):

https://codereview.chromium.org/1303363006/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/function_set.dart:58: /// This will reduces the
set of classes in [mask] to a [TypeMask] of the set
'reduces' -> 'reduce'.

https://codereview.chromium.org/1303363006/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/function_set.dart:114: assert(mask != null);
The initializer for hashCode uses mask as receiver, so the constructor will
throw for mask == null already.

https://codereview.chromium.org/1303363006/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/function_set.dart:243: /// A set of function that
are the potential targets of all call sites sharing
'function' -> 'functions'.

[Johnni Winther, 2015-09-01 11:54:47]

https://codereview.chromium.org/1303363006/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/function_set.dart (right):

https://codereview.chromium.org/1303363006/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/function_set.dart:58: /// This will reduces the
set of classes in [mask] to a [TypeMask] of the set
On 2015/09/01 07:47:03, karlklose wrote:
> 'reduces' -> 'reduce'.

Done.

https://codereview.chromium.org/1303363006/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/function_set.dart:114: assert(mask != null);
On 2015/09/01 07:47:03, karlklose wrote:
> The initializer for hashCode uses mask as receiver, so the constructor will
> throw for mask == null already.

Null implements hashCode so it will not fail.

https://codereview.chromium.org/1303363006/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/function_set.dart:243: /// A set of function that
are the potential targets of all call sites sharing
On 2015/09/01 07:47:03, karlklose wrote:
> 'function' -> 'functions'.

Done.

[Johnni Winther, 2015-09-01 11:59:20]

Committed patchset #2 (id:20001) manually as
df3b310e683cbd094bf5be054f9979a66303708a (presubmit successful).

[Siggi Cherem (dart-lang), 2015-09-01 20:12:12]

lgtm