Issue 1303343008: Extension point for AnalysisResultListener(s).

Issue 1303343008: Extension point for AnalysisResultListener(s). (Closed)

Created:
5 years, 3 months ago by scheglov

Modified:
5 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Extension point for AnalysisResultListener(s). The plan is that plugins will listen for computed results. For example the Angular plugin will listen for DART_TEMPLATES and once it sees one, it will schedule sending the navigation notification, because now the other extension - NavigationContributor can produce its navigation regions. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/dfd09f3f66cdb4a6d877e69eff0422eed86b73f7

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : Update to make plugins to listen for results, not contexts. #

Patch Set 4 : Renames in test #

Patch Set 5 : Replace with SetAnalysisDomain() function. #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+338 lines, -13 lines)			Patch
A	pkg/analysis_server/lib/analysis/analysis_domain.dart	View	1 2 3 4	1 chunk	+53 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/domain_analysis.dart	View	1 2 3 4	3 chunks	+78 lines, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/plugin/server_plugin.dart	View	1 2 3 4	7 chunks	+36 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/analysis_abstract.dart	View	1	4 chunks	+19 lines, -6 lines	1 comment	Download
A	pkg/analysis_server/test/plugin/set_analysis_domain_test.dart	View	1 2 3 4	1 chunk	+146 lines, -0 lines	0 comments	Download
A +	pkg/analysis_server/test/plugin/test_all.dart	View	1 2 3 4	1 chunk	+4 lines, -5 lines	0 comments	Download
M	pkg/analysis_server/test/test_all.dart	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1303343008/diff/80001/pkg/analysis_server/test/analysis_abstract.dart File pkg/analysis_server/test/analysis_abstract.dart (right): https://codereview.chromium.org/1303343008/diff/80001/pkg/analysis_server/test/analysis_abstract.dart#newcode185 pkg/analysis_server/test/analysis_abstract.dart:185: handler = server.handlers.singleWhere((_) => _ is AnalysisDomainHandler); I ...

5 years, 3 months ago (2015-09-04 16:54:31 UTC) #4

scheglov

5 years, 3 months ago (2015-09-04 16:56:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 (id:80001) manually as
dfd09f3f66cdb4a6d877e69eff0422eed86b73f7 (presubmit successful).

Expand Messages | Collapse Messages