improve keyword suggestions - fixes #24016

improve keyword suggestions - fixes #24016

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/bd95b13b90ded36c17de394a2fef42b75ec6e6c7

[danrubel, 2015-08-26 20:26:20]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-08-26 20:33:20]

LGTM

https://codereview.chromium.org/1303233008/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart
(right):

https://codereview.chromium.org/1303233008/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart:428:
Keyword.NEW,
If we suggest 'new', shouldn't we also suggest 'const'?

https://codereview.chromium.org/1303233008/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart:437:
_addSuggestion(Keyword.RETHROW, DART_RELEVANCE_KEYWORD - 1);
Seems like we should only suggest this if we're inside a catch block, in which
case the relevance should be as high as any other keyword.

https://codereview.chromium.org/1303233008/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart:480:
return true;
If we're inside a method declaration, given that this is used for 'this' and
'super', we should check that it doesn't have a 'super' modifier.

[danrubel, 2015-08-26 21:35:00]

Committed patchset #3 (id:40001) manually as
bd95b13b90ded36c17de394a2fef42b75ec6e6c7 (presubmit successful).

[danrubel, 2015-08-26 21:39:29]

https://codereview.chromium.org/1303233008/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart
(right):

https://codereview.chromium.org/1303233008/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart:428:
Keyword.NEW,
On 2015/08/26 20:33:20, Brian Wilkerson wrote:
> If we suggest 'new', shouldn't we also suggest 'const'?

Good suggestion. Done.

https://codereview.chromium.org/1303233008/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart:437:
_addSuggestion(Keyword.RETHROW, DART_RELEVANCE_KEYWORD - 1);
On 2015/08/26 20:33:20, Brian Wilkerson wrote:
> Seems like we should only suggest this if we're inside a catch block, in which
> case the relevance should be as high as any other keyword.

Good point. I'll address this in a subsequent CL.
https://github.com/dart-lang/sdk/issues/24214

https://codereview.chromium.org/1303233008/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart:480:
return true;
On 2015/08/26 20:33:20, Brian Wilkerson wrote:
> If we're inside a method declaration, given that this is used for 'this' and
> 'super', we should check that it doesn't have a 'super' modifier.

Not sure what you mean here. Isn't this valid thus we should suggest super?

class A {
  var x;
}
class B extends A {
  B() : super() {super.x = 7;}
}