Navigation extension point.

Navigation extension point.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/b15a031276563525cb1a31c2fb4206c6a49de951

[Brian Wilkerson, 2015-09-01 14:55:42]

LGTM, once comments are addressed

https://codereview.chromium.org/1303033010/diff/1/pkg/analysis_server/lib/ana...
File pkg/analysis_server/lib/analysis/navigation/navigation_core.dart (right):

https://codereview.chromium.org/1303033010/diff/1/pkg/analysis_server/lib/ana...
pkg/analysis_server/lib/analysis/navigation/navigation_core.dart:33: abstract
class NavigationHolder {
I don't think clients need the getters, so I'd like to remove them. Internally,
the method that computes navigations can return a NavigationHolderImpl.

https://codereview.chromium.org/1303033010/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/operation/operation_analysis.dart (right):

https://codereview.chromium.org/1303033010/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/operation/operation_analysis.dart:391: //
TODO(scheglov) get rid of "file" and replace it with "source"?
Is this done? I don't see a 'file' being referenced here.

[scheglov, 2015-09-01 20:06:14]

https://codereview.chromium.org/1303033010/diff/1/pkg/analysis_server/lib/ana...
File pkg/analysis_server/lib/analysis/navigation/navigation_core.dart (right):

https://codereview.chromium.org/1303033010/diff/1/pkg/analysis_server/lib/ana...
pkg/analysis_server/lib/analysis/navigation/navigation_core.dart:33: abstract
class NavigationHolder {
On 2015/09/01 14:55:42, Brian Wilkerson wrote:
> I don't think clients need the getters, so I'd like to remove them.
Internally,
> the method that computes navigations can return a NavigationHolderImpl.

Done.

[scheglov, 2015-09-01 20:06:31]

Committed patchset #2 (id:20001) manually as
b15a031276563525cb1a31c2fb4206c6a49de951 (presubmit successful).