Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1302693003: Update status of pkgbuild test for shelf, update dart2js_info to fix pkgbuild test for args (Closed)

Created:
5 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 4 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org, ricow1, nweiz
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update status of pkgbuild test for shelf, update dart2js_info to fix pkgbuild test for args (args was an easy fix, just downgrade within the same major version. shelf requires switching to 0.5.7 from 0.6.2 which might involve working around breaking changes, so I'll do so more calmly later.) Committed: https://github.com/dart-lang/sdk/commit/a984fb2b72f4a3567ecde8e89a7067c931c28f16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M pkg/pkgbuild.status View 1 chunk +1 line, -0 lines 0 comments Download
M tools/deps/dartium.deps/DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Siggi Cherem (dart-lang)
TBR Natalie - I imagine shelf is mainly needed here for pub, which currently has ...
5 years, 4 months ago (2015-08-19 03:57:11 UTC) #2
Siggi Cherem (dart-lang)
Committed patchset #1 (id:1) manually as a984fb2b72f4a3567ecde8e89a7067c931c28f16 (presubmit successful).
5 years, 4 months ago (2015-08-19 03:57:25 UTC) #3
Harry Terkelsen
5 years, 4 months ago (2015-08-19 17:05:35 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698