Only test optimizing compilation in helper thread compilation test.

Only test optimizing compilation in helper thread compilation test.

Also fix a couple of old handles (leaving the bulk of them for a separate CL).

BUG=
R=srdjan@google.com

Committed: https://github.com/dart-lang/sdk/commit/6636b92090d35990b80b1859bf6bd123c4befb42

[koda, 2015-08-18 22:13:19]

koda@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2015-08-18 23:07:18]

https://codereview.chromium.org/1302623002/diff/20001/runtime/vm/compiler_tes...
File runtime/vm/compiler_test.cc (right):

https://codereview.chromium.org/1302623002/diff/20001/runtime/vm/compiler_tes...
runtime/vm/compiler_test.cc:91: EXPECT(!func_.HasOptimizedCode());
Assert that function has (unoptimized) code. We expect certain objects to be
allocated/computed  during unoptimized compilation before we can use them in
optimized compilation.

[koda, 2015-08-19 00:16:33]

PTAL

https://codereview.chromium.org/1302623002/diff/20001/runtime/vm/compiler_tes...
File runtime/vm/compiler_test.cc (right):

https://codereview.chromium.org/1302623002/diff/20001/runtime/vm/compiler_tes...
runtime/vm/compiler_test.cc:91: EXPECT(!func_.HasOptimizedCode());
On 2015/08/18 23:07:18, srdjan wrote:
> Assert that function has (unoptimized) code. We expect certain objects to be
> allocated/computed  during unoptimized compilation before we can use them in
> optimized compilation.

Yes, although I'm already doing that in the code below, it does make sense to do
it again here, if it's a precondition of the method we're calling.

[srdjan, 2015-08-19 16:39:09]

lgtm

[koda, 2015-08-19 16:43:00]

Committed patchset #3 (id:40001) manually as
6636b92090d35990b80b1859bf6bd123c4befb42 (presubmit successful).