Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1302533003: Highlight the whole token when marking the current execution. Truncate call site annotations to one… (Closed)

Created:
5 years, 4 months ago by rmacnak
Modified:
5 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Highlight the whole token when marking the current execution. Truncate call site annotations to one token. Fix display of retained size for a class's top retaining instances for non-Instances. Fix type of Instance.pattern. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/b7a8c29d92d0e8b7c2d9f8b6e8982a8b155dc920

Patch Set 1 #

Patch Set 2 : top retainer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -10 lines) Patch
M runtime/observatory/lib/src/elements/script_inset.dart View 2 chunks +11 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 3 chunks +67 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 4 months ago (2015-08-19 00:19:40 UTC) #2
Cutch
lgtm
5 years, 4 months ago (2015-08-19 19:56:11 UTC) #3
rmacnak
5 years, 4 months ago (2015-08-19 20:10:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b7a8c29d92d0e8b7c2d9f8b6e8982a8b155dc920 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698