Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1302333006: Support metadata on patches. (Closed)

Created:
5 years, 3 months ago by Johnni Winther
Modified:
5 years, 3 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Siggi Cherem (dart-lang)
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove partial renaming #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+768 lines, -711 lines) Patch
M pkg/compiler/lib/src/deferred_load.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 9 chunks +68 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 3 chunks +15 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/metadata_collector.dart View 2 chunks +9 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 4 chunks +11 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/parser/member_listener.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 5 chunks +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 7 chunks +7 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/util/link.dart View 1 chunk +16 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/util/link_implementation.dart View 3 chunks +15 lines, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/developer_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/metadata_test.dart View 6 chunks +18 lines, -18 lines 0 comments Download
M tests/compiler/dart2js/mirrors_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 15 chunks +583 lines, -584 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -3 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
Main changes in elements.dart and modelx.dart
5 years, 3 months ago (2015-09-09 10:14:58 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/1302333006/diff/20001/tests/standalone/standalone.status File tests/standalone/standalone.status (left): https://codereview.chromium.org/1302333006/diff/20001/tests/standalone/standalone.status#oldcode190 tests/standalone/standalone.status:190: io/observatory_test: Crash # Issue 24291 Is that due ...
5 years, 3 months ago (2015-09-09 10:28:26 UTC) #3
Johnni Winther
https://codereview.chromium.org/1302333006/diff/20001/tests/standalone/standalone.status File tests/standalone/standalone.status (left): https://codereview.chromium.org/1302333006/diff/20001/tests/standalone/standalone.status#oldcode190 tests/standalone/standalone.status:190: io/observatory_test: Crash # Issue 24291 On 2015/09/09 10:28:26, karlklose ...
5 years, 3 months ago (2015-09-09 10:50:50 UTC) #4
Johnni Winther
5 years, 3 months ago (2015-09-09 11:05:04 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
8855bc8161acb4336319ebfe204b3cb78710175b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698