Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1302333005: Shift AnalysisError instances only once during incremental resolution. (Closed)

Created:
5 years, 3 months ago by scheglov
Modified:
5 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Shift AnalysisError instances only once during incremental resolution. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/85dadad5f71c097f708ea5124f57394c5779c247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 3 months ago (2015-09-08 23:51:49 UTC) #1
Brian Wilkerson
LGTM
5 years, 3 months ago (2015-09-09 00:44:34 UTC) #2
scheglov
5 years, 3 months ago (2015-09-09 00:47:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
85dadad5f71c097f708ea5124f57394c5779c247 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698