Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1302313003: Static analysis fixes and debug prints for wedging test (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Static analysis fixes and debug prints for wedging test BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/a9be61a3584c75464605faca3700dab5948e18a5

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M runtime/bin/vmservice_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/pause_on_start_then_step_test.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/disassembler_ia32.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/profiler_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 4 months ago (2015-08-21 20:33:43 UTC) #2
rmacnak
LGTM
5 years, 4 months ago (2015-08-21 20:51:03 UTC) #3
Cutch
5 years, 4 months ago (2015-08-21 21:31:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a9be61a3584c75464605faca3700dab5948e18a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698