Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1301533003: Plumb "enableSuperMixins" option through analysis server (implements DEP 34). (Closed)

Created:
5 years, 4 months ago by Paul Berry
Modified:
5 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Plumb "enableSuperMixins" option through analysis server (implements DEP 34). Partially addresses #23772. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/03a156c8913f510c821bab48b04ff9673c00fc38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -4 lines) Patch
M pkg/analysis_server/doc/api.html View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 9 chunks +29 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/get_handler.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/status/get_handler.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/error_test.dart View 1 chunk +60 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/types/AnalysisOptions.java View 8 chunks +25 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 4 months ago (2015-08-20 16:31:57 UTC) #2
scheglov
LGTM
5 years, 4 months ago (2015-08-20 16:35:43 UTC) #3
Paul Berry
5 years, 4 months ago (2015-08-20 16:47:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
03a156c8913f510c821bab48b04ff9673c00fc38 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698