Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1301373009: Fix typo in lookup map, use pub_semver to check version constraints in dart2js (Closed)

Created:
5 years, 3 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 3 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix typo in lookup map, use pub_semver to check version constraints in dart2js R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/d78be6beb02f53f3663de285889a7e2bf61317cf

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 3 chunks +10 lines, -2 lines 0 comments Download
M pkg/compiler/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/lookup_map/CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/lookup_map/README.md View 1 chunk +1 line, -1 line 0 comments Download
M pkg/lookup_map/lib/lookup_map.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/lookup_map/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Siggi Cherem (dart-lang)
https://codereview.chromium.org/1301373009/diff/1/pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart File pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart (left): https://codereview.chromium.org/1301373009/diff/1/pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart#oldcode166 pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart:166: if (version != '0.0.1') { I had a feeling ...
5 years, 3 months ago (2015-09-08 20:25:34 UTC) #2
Siggi Cherem (dart-lang)
5 years, 3 months ago (2015-09-08 20:25:42 UTC) #4
Siggi Cherem (dart-lang)
oops, forgot to include the actual change on the version number. Please ignore Patchset 1
5 years, 3 months ago (2015-09-08 20:28:31 UTC) #5
sra1
lgtm
5 years, 3 months ago (2015-09-08 21:07:23 UTC) #6
Siggi Cherem (dart-lang)
5 years, 3 months ago (2015-09-08 21:51:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d78be6beb02f53f3663de285889a7e2bf61317cf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698