dart2js cps: Generate fast checks for 'is String' and 'is bool'.

dart2js cps: Generate fast checks for 'is String' and 'is bool'.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/5d575f307c840809164ed5a6d0ba7ea9caf690b9

[sra1, 2015-08-20 22:34:21]

sra@google.com changed reviewers:
+ asgerf@google.com

[sra1, 2015-08-21 20:20:52]

ping

[Siggi Cherem (dart-lang), 2015-08-21 23:57:10]

sigmund@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2015-08-21 23:57:11]

lgtm

https://codereview.chromium.org/1301363002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right):

https://codereview.chromium.org/1301363002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:362: // precondtion that
[value] is an Array. They will crash on `null`.
precondtion => precondition

[sra1, 2015-08-22 00:11:56]

https://chromiumcodereview.appspot.com/1301363002/diff/1/pkg/compiler/lib/src...
File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right):

https://chromiumcodereview.appspot.com/1301363002/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:362: // precondtion that
[value] is an Array. They will crash on `null`.
On 2015/08/21 23:57:11, Siggi Cherem (dart-lang) wrote:
> precondtion => precondition

Done.

[sra1, 2015-08-22 00:41:35]

Committed patchset #2 (id:20001) manually as
5d575f307c840809164ed5a6d0ba7ea9caf690b9 (presubmit successful).

[asgerf, 2015-08-25 08:46:22]

Also LGTM (was on vacation).