Issue 1300963003: changelog updates for dartdoc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1300963003: changelog updates for dartdoc (Closed)

Created:
5 years, 4 months ago by sethladd

Modified:
5 years, 4 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org, keertip

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

changelog updates for dartdoc BUG= R=kevmoo@google.com Committed: https://github.com/dart-lang/sdk/commit/c2d49794ffea8423178fbd7fe7b5b39efba642ec

Patch Set 2 : also mention docgen #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	CHANGELOG.md	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kevmoo

LGTM w/ a question/suggestion https://codereview.chromium.org/1300963003/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1300963003/diff/1/CHANGELOG.md#newcode148 CHANGELOG.md:148: * dartdocgen Also mention 'docgen' ...

5 years, 4 months ago (2015-08-18 22:29:05 UTC) #3

sethladd

Committed patchset #2 (id:20001) manually as c2d49794ffea8423178fbd7fe7b5b39efba642ec (presubmit successful).

5 years, 4 months ago (2015-08-18 22:30:35 UTC) #4

sethladd

5 years, 4 months ago (2015-08-18 22:31:10 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/1300963003/diff/1/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/1300963003/diff/1/CHANGELOG.md#newcode148
CHANGELOG.md:148: * dartdocgen
On 2015/08/18 22:29:05, kevmoo wrote:
> Also mention 'docgen' being removed? Guessing that will go away in 1.13, too?

Done.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1300963003: changelog updates for dartdoc (Closed)

Description

Patch Set 1 #

Patch Set 2 : also mention docgen #

Messages