Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 13009004: Added EXPECT_TRUE macro, updated debugger unit tests to use it for (Closed)

Created:
7 years, 9 months ago by Tom Ball
Modified:
7 years, 9 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Added EXPECT_TRUE macro, updated debugger unit tests to use it for API calls that return True. Committed: https://code.google.com/p/dart/source/detail?r=20450

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
M runtime/vm/debugger_api_impl_test.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M runtime/vm/unit_test.h View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Ball
This CL doesn't catch any new issues, but since Ivan wants me to work on ...
7 years, 9 months ago (2013-03-22 18:26:39 UTC) #1
hausner
LGTM
7 years, 9 months ago (2013-03-22 18:33:11 UTC) #2
Tom Ball
7 years, 9 months ago (2013-03-25 16:22:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20450 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698