Issue 13009002: Fix bug 4898:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13009002: Fix bug 4898: (Closed)

Created:
7 years, 9 months ago by Ivan Posva

Modified:
7 years, 9 months ago

Reviewers:
gbracha

CC:
reviews_dartlang.org, ngeoffray

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bug 4898: - Mark test as runtime error based on the spec. - Update status files for dartc, dart2dart and dart2js. Committed: https://code.google.com/p/dart/source/detail?r=20407

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
M	tests/language/getter_no_setter2_test.dart	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/language/language.status	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	tests/language/language_dart2js.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

gbracha

lgtm with comments https://codereview.chromium.org/13009002/diff/1/tests/language/getter_no_setter2_test.dart File tests/language/getter_no_setter2_test.dart (right): https://codereview.chromium.org/13009002/diff/1/tests/language/getter_no_setter2_test.dart#newcode13 tests/language/getter_no_setter2_test.dart:13: nextVar++; Isn't this a static warning ...

7 years, 9 months ago (2013-03-22 00:46:47 UTC) #2

Ivan Posva

https://codereview.chromium.org/13009002/diff/1/tests/language/getter_no_setter2_test.dart File tests/language/getter_no_setter2_test.dart (right): https://codereview.chromium.org/13009002/diff/1/tests/language/getter_no_setter2_test.dart#newcode13 tests/language/getter_no_setter2_test.dart:13: nextVar++; On 2013/03/22 00:46:47, gbracha wrote: > Isn't this ...

7 years, 9 months ago (2013-03-22 03:45:50 UTC) #3

Ivan Posva

7 years, 9 months ago (2013-03-22 19:11:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20407 (presubmit successful).

Expand Messages | Collapse Messages

Issue 13009002: Fix bug 4898: (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages