Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1300853006: Functions are objects too! (Closed)

Created:
5 years, 4 months ago by rmacnak
Modified:
5 years, 4 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Functions are objects too! - Fix allInstances of non-Instances. - Fix loading _vmName. - Make refs of top-level classes (::) display something instead of empty string. - Fix inbound references to display C++ word offsets like retaining path. - Make inbound references and retaining path to display '<root>' instead of empty. - Make more types display heap object tools. - Add missing function kind for signature functions. BUG= R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/9162166b54ffcf73edcc947d3f85c265ff77dc2a

Patch Set 1 #

Patch Set 2 : update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -77 lines) Patch
M runtime/observatory/lib/src/elements/class_view.html View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/context_view.html View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/field_view.html View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/function_view.html View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/inbound_reference.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/inbound_reference.html View 1 chunk +9 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/library_view.html View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/object_common.html View 3 chunks +8 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_view.html View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 26 chunks +73 lines, -53 lines 0 comments Download
M runtime/observatory/tests/service/inbound_references_test.dart View 1 1 chunk +8 lines, -8 lines 0 comments Download
M runtime/vm/service.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 4 months ago (2015-08-19 17:17:45 UTC) #2
turnidge
lgtm
5 years, 4 months ago (2015-08-19 17:54:00 UTC) #3
rmacnak
5 years, 4 months ago (2015-08-19 18:18:26 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
9162166b54ffcf73edcc947d3f85c265ff77dc2a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698