Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 13008025: Client-side support for stacktrace VM status. (Closed)

Created:
7 years, 9 months ago by Tom Ball
Modified:
7 years, 8 months ago
Reviewers:
siva, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Client-side support for stacktrace VM status. Committed: https://code.google.com/p/dart/source/detail?r=20899

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -48 lines) Patch
M runtime/bin/vmstats/bargraph.dart View 1 2 6 chunks +9 lines, -7 lines 0 comments Download
M runtime/bin/vmstats/isolate_list.dart View 1 2 1 chunk +98 lines, -35 lines 0 comments Download
M runtime/bin/vmstats/models.dart View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/bin/vmstats/vmstats.css View 1 2 1 chunk +12 lines, -1 line 0 comments Download
M runtime/bin/vmstats/vmstats.dart View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M runtime/bin/vmstats/vmstats.html View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Tom Ball
These are the client-side changes to show stack traces. The UI isn't ready, but the ...
7 years, 9 months ago (2013-03-22 18:22:58 UTC) #1
Tom Ball
Added per-stackframe support to client, moved into separate, toggle-able panel.
7 years, 8 months ago (2013-04-02 00:03:27 UTC) #2
Ivan Posva
LGTM -ip
7 years, 8 months ago (2013-04-02 23:12:03 UTC) #3
Tom Ball
7 years, 8 months ago (2013-04-03 22:03:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r20899 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698