Issue 13006009: Add change to dartium source file in addition to the dart2js file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13006009: Add change to dartium source file in addition to the dart2js file. (Closed)

Created:
7 years, 9 months ago by Emily Fortuna

Modified:
7 years, 9 months ago

Reviewers:
Andrei Mouravski

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add change to dartium source file in addition to the dart2js file. BUG= Committed: https://code.google.com/p/dart/source/detail?r=20484

Patch Set 1 #

Total comments: 1

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	sdk/lib/html/dartium/html_dartium.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
	M	tools/dom/src/dartium_KeyEvent.dart	View		1 chunk	+3 lines, -3 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

TBR https://codereview.chromium.org/13006009/diff/1/tools/dom/src/dartium_KeyEvent.dart File tools/dom/src/dartium_KeyEvent.dart (right): https://codereview.chromium.org/13006009/diff/1/tools/dom/src/dartium_KeyEvent.dart#newcode57 tools/dom/src/dartium_KeyEvent.dart:57: new _KeyboardEventHandler('keydown'); This corresponding change in the dart2js_KeyEvent.dart ...

7 years, 9 months ago (2013-03-25 20:32:59 UTC) #1

Emily Fortuna

Committed patchset #1 manually as r20484 (presubmit successful).

7 years, 9 months ago (2013-03-25 20:34:14 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages