Added string appending to TextBuffer, removed STL use in vm_stats_impl.

Added string appending to TextBuffer, removed STL use in vm_stats_impl.
Committed: https://code.google.com/p/dart/source/detail?r=20566

[Tom Ball, 2013-03-25 20:20:23]

Not sure what, if anything, you want done with the existing STL use by the VM:

runtime/vm/heap_profiler.h
282:  std::set<const RawSmi*> smi_table_;
283:  std::set<const RawClass*> class_table_;
284:  std::set<const RawString*> string_table_;

runtime/vm/gc_marker.cc
152:    delay_set_.insert(std::make_pair(raw_key, raw_weak));
176:      std::pair<DelaySet::iterator, DelaySet::iterator> ret;
219:  typedef std::multimap<RawObject*, RawWeakProperty*> DelaySet;

runtime/vm/scavenger.h
158:  typedef std::map<RawObject*, void*> PeerTable;

runtime/vm/freelist.cc
181:  std::map<intptr_t, intptr_t> sorted;
182:  std::map<intptr_t, intptr_t>::iterator it;
190:      sorted.insert(std::make_pair(node->Size(), 1));

runtime/vm/heap_profiler.cc
144:  for (std::set<const RawSmi*>::iterator it = smi_table_.begin();

runtime/vm/pages.h
220:  typedef std::map<RawObject*, void*> PeerTable;

runtime/vm/scavenger.cc
104:    delay_set_.insert(std::make_pair(raw_key, raw_weak));
161:        std::pair<DelaySet::iterator, DelaySet::iterator> ret;
250:  typedef std::multimap<RawObject*, RawWeakProperty*> DelaySet;
604:  std::swap(prev, peer_table_);

runtime/vm/heap_trace_test.cc
18:static std::stringstream* global_stream;
22:  global_stream = new std::stringstream;
29:  std::stringstream* sstream = reinterpret_cast<std::stringstream*>(stream);
37:  delete reinterpret_cast<std::stringstream*>(stream);
41:bool DoesAllocationRecordExist(uword addr, const std::string& trace_string) {
56:bool DoesSweepRecordExist(uword addr, const std::string& trace_string) {

[Ivan Posva, 2013-03-25 21:29:17]

LGTM with comment.

-Ivan

https://codereview.chromium.org/13006007/diff/1/runtime/platform/json.h
File runtime/platform/json.h (right):

https://codereview.chromium.org/13006007/diff/1/runtime/platform/json.h#newco...
runtime/platform/json.h:131: void AddEscapedString(const char* s);
I don't see AddEscapedString being used anywhere yet. Should we add it when
necessary?

[Tom Ball, 2013-03-25 21:46:09]

https://codereview.chromium.org/13006007/diff/1/runtime/platform/json.h
File runtime/platform/json.h (right):

https://codereview.chromium.org/13006007/diff/1/runtime/platform/json.h#newco...
runtime/platform/json.h:131: void AddEscapedString(const char* s);
On 2013/03/25 21:29:17, Ivan Posva wrote:
> I don't see AddEscapedString being used anywhere yet. Should we add it when
> necessary?

I need it for the pending stacktrace CL, because JSON requires that newline
characters be escaped.

[Tom Ball, 2013-03-27 17:30:20]

Committed patchset #1 manually as r20566 (presubmit successful).